4
3%
master: 3%

Ran 19 Oct 2016 09:45PM UTC

Files 258

Run time 14s

Badge

Embed ▾

Committed 19 Oct 2016 09:32PM UTC coverage: 87.787% (-0.006%) from 87.793%

Job # TEST_SUITE=backend

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

event_queue: Eliminate buggy need_timeout heartbeat code.

As best I can tell, this option was completely confused in two ways:
* The name is confusing; it actually controls whether we _clear_ the
  timeout associated with the current handler
* It's not clear why one would not want it to be unconditionally true.

From reading the history, I'm pretty sure I had just misread the code
when I created this.

And this caused a real bug; a later refactoring caused us to basically
never cancel the timeouts, which in turn resulted in 90% of all events
traffic being hearbeats with a much lower frequency (~5s) than the
intended 45s.  Removing this code fixes that nasty bug.

Coverage Stats

21046 of 23974 relevant lines covered (87.79%)

0.88 hits per line

zulip / zulip / 6077 / 4
3%
master: 3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6077.4 (TEST_SUITE=backend)

zulip / zulip / 6077 / 4 3% master: 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 6077.4 (TEST_SUITE=backend)

zulip / zulip / 6077 / 4
3%
master: 3%

README BADGES
x