6077
3%

Ran 19 Oct 2016 09:39PM UTC

Jobs 7

Files 258

Run time 8min

Badge

Embed ▾

pending completion

Build # 6077

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

event_queue: Eliminate buggy need_timeout heartbeat code.

As best I can tell, this option was completely confused in two ways:
* The name is confusing; it actually controls whether we _clear_ the
  timeout associated with the current handler
* It's not clear why one would not want it to be unconditionally true.

From reading the history, I'm pretty sure I had just misread the code
when I created this.

And this caused a real bug; a later refactoring caused us to basically
never cancel the timeouts, which in turn resulted in 90% of all events
traffic being hearbeats with a much lower frequency (~5s) than the
intended 45s.  Removing this code fixes that nasty bug.

Coverage Stats

21056 of 23984 relevant lines covered (87.79%)

1.76 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	6077.1 (TEST_SUITE=frontend)	19 Oct 2016 09:39PM UTC		Travis Job 6077.1
2	6077.2 (TEST_SUITE=frontend)	19 Oct 2016 09:40PM UTC		Travis Job 6077.2
3	6077.3 (TEST_SUITE=backend)	19 Oct 2016 09:40PM UTC	87.77	Travis Job 6077.3
4	6077.4 (TEST_SUITE=backend)	19 Oct 2016 09:45PM UTC	87.79	Travis Job 6077.4
5	6077.5 (TEST_SUITE=static-analysis)	19 Oct 2016 09:44PM UTC		Travis Job 6077.5
6	6077.6 (TEST_SUITE=production)	19 Oct 2016 09:47PM UTC		Travis Job 6077.6
7	6077.7 (TEST_SUITE=production)	19 Oct 2016 09:47PM UTC		Travis Job 6077.7

Source Files on build 6077

Detailed source file information is not available for this build.

zulip / zulip / 6077
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6077

zulip / zulip / 6077 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 6077

zulip / zulip / 6077
3%

README BADGES
x