4
0%
master: 0%

Ran 18 Oct 2016 11:14PM UTC

Files 19

Run time 1s

Badge

Embed ▾

Committed 18 Oct 2016 11:02PM UTC coverage: 77.391%. Remained the same

Job # TOX_ENV=py27-mysql

Build Type

push

travis-ci

Committed by

mistercrunch

Commit Message

Enable "Run Query in New Tab" in SQL Lab (#1343)

* Enable "Clone to New Tab" btn in QueryHistoryTable

Method #1; doesn't feel very clean.

Going to attempt to reimplement using an action and changing state directly
through the reducer rather than creating a new QueryEditor object directly from
the QueryTable

* Move Clone Logic to Action

* Implement PR feedback

* Clean up reducer action; fix bug

Bug => Attempting to clone anything other than the most recent Query for a given
TabbedQueryEditor would throw an exception, because we depended on lastQueryId
to find the title of the QueryEditor to clone. Since you can only activate a
clone from the currently active tab, we can instead fetch the ID of the Editor
to copy the Title of from the tip of tabHistory.

* Tests for Reducer Action

* Fix CodeClimate feedback

Run Details

3553 of 4591 relevant lines covered (77.39%)

0.77 hits per line

airbnb / superset / 3855 / 4
0%
master: 0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3855.4 (TOX_ENV=py27-mysql)

airbnb / superset / 3855 / 4 0% master: 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 3855.4 (TOX_ENV=py27-mysql)

airbnb / superset / 3855 / 4
0%
master: 0%

README BADGES
x