3855
0%

Ran 18 Oct 2016 11:14PM CUT

Jobs 4

Files 19

Run time 3min

Badge

Embed ▾

pending completion

Build # 3855

Build Type

push

travis-ci

Committed by

mistercrunch

Commit Message

Enable "Run Query in New Tab" in SQL Lab (#1343)

* Enable "Clone to New Tab" btn in QueryHistoryTable

Method #1; doesn't feel very clean.

Going to attempt to reimplement using an action and changing state directly
through the reducer rather than creating a new QueryEditor object directly from
the QueryTable

* Move Clone Logic to Action

* Implement PR feedback

* Clean up reducer action; fix bug

Bug => Attempting to clone anything other than the most recent Query for a given
TabbedQueryEditor would throw an exception, because we depended on lastQueryId
to find the title of the QueryEditor to clone. Since you can only activate a
clone from the currently active tab, we can instead fetch the ID of the Editor
to copy the Title of from the tip of tabHistory.

* Tests for Reducer Action

* Fix CodeClimate feedback

Run Details

3570 of 4591 relevant lines covered (77.76%)

3.09 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	3855.2 (TOX_ENV=py34-postgres)	18 Oct 2016 11:17PM CUT	19	77.06	Travis Job 3855.2
3	3855.3 (TOX_ENV=py34-sqlite)	18 Oct 2016 11:14PM CUT	19	77.5	Travis Job 3855.3
4	3855.4 (TOX_ENV=py27-mysql)	18 Oct 2016 11:14PM CUT	19	77.39	Travis Job 3855.4
5	3855.5 (TOX_ENV=py27-sqlite)	18 Oct 2016 11:15PM CUT	19	77.48	Travis Job 3855.5

Source Files on build 3855

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	caravel/migrations/env.py	100	40	0	40	0.0
0.0	caravel/extract_table_names.py	60	34	0	34	0.0
59.74	caravel/bin/caravel	155	77	46	31	1.0
61.33	caravel/views.py	2264	1068	655	413	1.0
73.13	caravel/__init__.py	112	67	49	18	1.0
77.89	caravel/sql_lab.py	157	95	74	21	1.0
78.79	caravel/utils.py	493	264	208	56	1.0
82.58	caravel/models.py	2344	1280	1057	223	1.0
82.95	caravel/viz.py	2031	991	822	169	1.0
85.51	caravel/db_engine_specs.py	214	69	59	10	1.0
95.24	caravel/source_registry.py	50	21	20	1	1.0

Showing 1 to 10 of 19 entries

airbnb / superset / 3855
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3855

airbnb / superset / 3855 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 3855

airbnb / superset / 3855
0%

README BADGES
x