4
3%
master: 3%

Ran 18 Oct 2016 03:19AM UTC

Files 258

Run time 16s

Badge

Embed ▾

Committed 18 Oct 2016 02:58AM UTC coverage: 87.791%. Remained the same

Job # TEST_SUITE=backend

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

Clean up startup code for streams.

The startup code in subs.js used to intermingle data
stuff and UI stuff in a loop inside a called function,
which made the code hard to reason about.

Now there is a clear separation of concerns, with these methods
being called in succession:

    stream_data.initialize_from_page_params();
    stream_list.create_initial_sidebar_rows();

The first method was mostly extracted from subs.js, but I simplified
some things, like not needing to make a copy of the hashes
we were passed in, plus I now garbage collect email_dict.  Also,
the code path that initialize_from_page_params() mostly replaces
used to call create_sub(), which fired a trigger, but now it
just does data stuff.

Once the data structure is built up, it's a very simple matter
to build the initial sidebar rows, and that's what the second
method does.

Run Details

21039 of 23965 relevant lines covered (87.79%)

0.88 hits per line

zulip / zulip / 5996 / 4
3%
master: 3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5996.4 (TEST_SUITE=backend)

zulip / zulip / 5996 / 4 3% master: 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 5996.4 (TEST_SUITE=backend)

zulip / zulip / 5996 / 4
3%
master: 3%

README BADGES
x