5996
3%

Ran 18 Oct 2016 03:11AM UTC

Jobs 7

Files 258

Run time 9min

Badge

Embed ▾

pending completion

Build # 5996

Build Type

push

travis-ci

Committed by

timabbott

Commit Message

Clean up startup code for streams.

The startup code in subs.js used to intermingle data
stuff and UI stuff in a loop inside a called function,
which made the code hard to reason about.

Now there is a clear separation of concerns, with these methods
being called in succession:

    stream_data.initialize_from_page_params();
    stream_list.create_initial_sidebar_rows();

The first method was mostly extracted from subs.js, but I simplified
some things, like not needing to make a copy of the hashes
we were passed in, plus I now garbage collect email_dict.  Also,
the code path that initialize_from_page_params() mostly replaces
used to call create_sub(), which fired a trigger, but now it
just does data stuff.

Once the data structure is built up, it's a very simple matter
to build the initial sidebar rows, and that's what the second
method does.

Run Details

21049 of 23975 relevant lines covered (87.8%)

1.76 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	5996.1 (TEST_SUITE=frontend)	18 Oct 2016 03:11AM UTC		Travis Job 5996.1
2	5996.2 (TEST_SUITE=frontend)	18 Oct 2016 03:12AM UTC		Travis Job 5996.2
3	5996.3 (TEST_SUITE=backend)	18 Oct 2016 03:12AM UTC	87.77	Travis Job 5996.3
4	5996.4 (TEST_SUITE=backend)	18 Oct 2016 03:19AM UTC	87.79	Travis Job 5996.4
5	5996.5 (TEST_SUITE=static-analysis)	18 Oct 2016 03:16AM UTC		Travis Job 5996.5
6	5996.6 (TEST_SUITE=production)	18 Oct 2016 03:20AM UTC		Travis Job 5996.6
7	5996.7 (TEST_SUITE=production)	18 Oct 2016 03:21AM UTC		Travis Job 5996.7

Source Files on build 5996

Detailed source file information is not available for this build.

zulip / zulip / 5996
3%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5996

zulip / zulip / 5996 3%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5996

zulip / zulip / 5996
3%

README BADGES
x