2
84%
master: 84%

Ran 05 Oct 2016 03:42AM UTC

Files 10

Run time 0s

Badge

Embed ▾

Committed 05 Oct 2016 03:22AM UTC coverage: 84.242%. Remained the same

Job # 421.2

Build Type

push

travis-ci

Committed by

lepture

Commit Message

Improve handling of github authorization error (#279)

First, thanks for the library!

I don't see a way for the `authorized_response` method to ever return `None`. Regardless, it seems possible that the response could be something other than `None` like an `OAuthException` so checking for only `None` seem insufficient.

This change fixes the situation where `authorized_response` returns something other than `None` but there is no `access_token` in the response.  I've been seeing this fail on my app with a `KeyError` on line 51.  So, I'm currently losing the real error from github which could explain *why* the `access_token` is missing.

Am I missing something?

Run Details

1144 of 1358 relevant lines covered (84.24%)

0.84 hits per line

lepture / flask-oauthlib / 421 / 2
84%
master: 84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 421.2

lepture / flask-oauthlib / 421 / 2 84% master: 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 421.2

lepture / flask-oauthlib / 421 / 2
84%
master: 84%

README BADGES
x