421
84%

Ran 05 Oct 2016 03:42AM UTC

Jobs 2

Files 10

Run time 37min

Badge

Embed ▾

pending completion

Build # 421

Build Type

push

travis-ci

Committed by

lepture

Commit Message

Improve handling of github authorization error (#279)

First, thanks for the library!

I don't see a way for the `authorized_response` method to ever return `None`. Regardless, it seems possible that the response could be something other than `None` like an `OAuthException` so checking for only `None` seem insufficient.

This change fixes the situation where `authorized_response` returns something other than `None` but there is no `access_token` in the response.  I've been seeing this fail on my app with a `KeyError` on line 51.  So, I'm currently losing the real error from github which could explain *why* the `access_token` is missing.

Am I missing something?

Run Details

1145 of 1358 relevant lines covered (84.32%)

1.68 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	421.2	05 Oct 2016 03:42AM UTC	0	84.24	Travis Job 421.2
4	421.4	05 Oct 2016 04:20AM UTC	0	84.09	Travis Job 421.4

Source Files on build 421

Detailed source file information is not available for this build.

lepture / flask-oauthlib / 421
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 421

lepture / flask-oauthlib / 421 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 421

lepture / flask-oauthlib / 421
84%

README BADGES
x