2
54%
master: 55%

Ran 31 Jul 2026 01:03PM UTC

Files 59

Run time 2s

Badge

Embed ▾

Committed 31 Jul 2026 12:41PM UTC coverage: 54.471% (+0.06%) from 54.412%

Job # 30631577385.2

Build Type

Pull #1417

github

Committed by

milanobrtlik

Commit Message

fix: propagate migration body read errors to the database driver

Migration.Buffer closes bufferWriter in a deferred call so that readers of
BufferedBody can never block (#1308). Because io.PipeWriter.Close closes with
a nil error, the reader observes a clean io.EOF even when reading the
migration body failed.

The read error itself only reaches m.logErr in the goroutine started by
readUp/readDown, and logErr is a no-op when no logger is configured. So on a
failed body read runMigrations hands the driver a truncated (or empty) body,
Run returns nil, and the migration is recorded as applied and clean:

	SetVersion(target, dirty=true)
	Run(BufferedBody)  -> reads EOF, executes partial SQL, returns nil
	SetVersion(target, dirty=false)

Close the pipe with the read error instead, so the driver fails, the error
reaches the caller, and the version is correctly left dirty.

Pull Request Pull Request #1417: fix: propagate migration body read errors to the database driver

Coverage Stats

4386 of 8052 relevant lines covered (54.47%)

24.88 hits per line

golang-migrate / migrate / 30631577385 / 2
54%
master: 55%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job Go-1.25.x - 30631577385.2

golang-migrate / migrate / 30631577385 / 2 54% master: 55%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job Go-1.25.x - 30631577385.2

golang-migrate / migrate / 30631577385 / 2
54%
master: 55%

README BADGES
x