golang-migrate / migrate / 30631577385

54%

master: 55%

Pull #1417

github

fix: propagate migration body read errors to the database driver

Migration.Buffer closes bufferWriter in a deferred call so that readers of
BufferedBody can never block (#1308). Because io.PipeWriter.Close closes with
a nil error, the reader observes a clean io.EOF even when reading the
migration body failed.

The read error itself only reaches m.logErr in the goroutine started by
readUp/readDown, and logErr is a no-op when no logger is configured. So on a
failed body read runMigrations hands the driver a truncated (or empty) body,
Run returns nil, and the migration is recorded as applied and clean:

	SetVersion(target, dirty=true)
	Run(BufferedBody)  -> reads EOF, executes partial SQL, returns nil
	SetVersion(target, dirty=false)

Close the pipe with the read error instead, so the driver fails, the error
reaches the caller, and the version is correctly left dirty.

6 of 8 new or added lines in 1 file covered. (75.0%)

4386 of 8052 relevant lines covered (54.47%)

49.77 hits per line