kobotoolbox / kpi / 30267991509 / 8

82%

master: 76%

push

github

fix(tags): return each tag once from `/api/v2/tags/` DEV-1576 (#7315)

### 📣 Summary
`TagViewSet.get_queryset()` filters across the `taggit_taggeditem` join
table, so a tag attached to N accessible assets was emitted N times,
`.distinct()` collapses it back to one row per tag.

### 📖 Description
`TagViewSet.get_queryset()` filters `Tag` on
`taggit_taggeditem_items__*` to restrict tags to assets the user may
view. Because that filter spans a multi-valued relationship, the
underlying SQL joins `taggit_tag` onto `taggit_taggeditem` and returns
one row per tag/asset pairing so a tag applied to two accessible assets
came back twice, with an identica `name` and `url`.

7133 of 12822 branches covered (55.63%)

25255 of 37653 relevant lines covered (67.07%)

0.67 hits per line