moonbitlang / core / 5499 / 1
91%
main: 91%

DEFAULT BRANCH: main
Ran
Files 437
Run time 9s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.286%. Remained the same
5499.1

push

github

bobzhang 
feat(bigint): make trait promotions explicit via extend

Enable `implicit_impl_as_method` (E0079) for the `bigint` package and make its
trait-impl promotions explicit, in a dedicated bigint/extends.mbt shim.

- Promote (plain `pub extend`): `BigInt`'s arithmetic/bitwise (Add/Sub/Mul/Div/
  Mod/Neg/BitAnd/BitOr/BitXOr), `Compare::{compare}`, `Default`, `ToJson::{to_json}`.
- Deprecate (`#deprecated(..., skip_current_package=true)` + `#doc(hidden)`):
  `Compare::{op_ge,op_gt,op_le,op_lt}`, `Eq`, `Hash`, `Show::{output}`,
  `@debug.Debug::{to_repr}`, `@json.FromJson::{from_json}`,
  `@quickcheck.Arbitrary::{arbitrary}`.

Two non-mechanical details:
- JS extern collision: bigint_js.mbt's `extern "js" fn BigInt::compare` / `::equal`
  share names with the promoted `Compare::{compare}` / `Eq` (E4056, JS target). The
  externs are renamed to `compare_js` / `equal_js` (private -> not in the .mbti) and
  their two impl bodies updated to call the renamed externs.
- `BigInt::to_json` is PROMOTED, not deprecated: it has cross-package method-syntax
  callers (builtin/json tests); deprecating it would break the `--deny-warn`
  workspace build (mirrors builtin/float). bigint's own blackbox-test callers of the
  deprecated `hash`/`arbitrary` are migrated to `Hash::hash(x)` /
  `@quickcheck.Arbitrary::arbitrary` (scoped to bigint/bigint_test.mbt).

Part of the per-package series (see #3849 for deque). Scoped to bigint/.

Verified: `moon check --deny-warn --target all` clean; `moon test -p bigint --target all` green (140 js / 165 native).

Reviewed by Codex CLI: E0079 cleared; arithmetic/compare/default/to_json promoted, rest deprecated+hidden;
JS externs renamed to avoid collision; to_json promoted to avoid cross-package ripple; scoped to bigint/.

Signed-off-by: Codex CLI <codex@openai.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

15912 of 17431 relevant lines covered (91.29%)

188744.25 hits per line

Source Files on job 5499.1