kobotoolbox / kpi / 29853932907 / 9

82%

master: 76%

push

github

fix(import): forbid duplicate names on import DEV-2167 (#7240)

### 📣 Summary
Do not allow users to import XLS files with duplicate names.

### 📖 Description
Previously, users were allowed to import XLS files with duplicate names
that were then renamed on deploy. Update the import process to no longer
allow this.


### 👀 Preview steps
Make sure to restart the worker after switching branches

1. ℹ️ have an account
2. Upload
https://docs.google.com/spreadsheets/d/e/2PACX-1vQAXAkJ9s4PNFyZhI8cmzbGCdApK2u5YcDjArt4gXaxbjKa0oiNHp0-hLW7Jaz-OA/pub?output=xlsx
to create a new asset
3. 🔴 [on main] Upload succeeds
4. [on main] Deploy
5. [on main] Add a submission with two audio responses
6. [on main] Navigate to data table and click Open on the audio file in
the second group
7. 🔴 [on main] path not found / recognized
8. 🟢 [on PR] upload is forbidden
9. 🟢 [on PR] regression tests: ensure an existing form with duplicates
can be exported
10. [on PR] redeploy the asset uploaded when on the main branch
11. 🟢 [on PR] Duplicate name error

6093 of 12686 branches covered (48.03%)

22513 of 37391 relevant lines covered (60.21%)

0.6 hits per line