1
79%
main: 79%

Ran 17 Jul 2026 12:45AM UTC

Files 62

Run time 4s

Badge

Embed ▾

Committed 17 Jul 2026 12:14AM UTC coverage: 78.742% (+0.05%) from 78.688%

Job # 29544834853.1

Build Type

Pull #625

github

Committed by

alvarorichard

Commit Message

fix: guard pageImpl.frames with lock to fix data race in Page.Frames()

pageImpl.frames was written by the connection dispatch goroutine
(onFrameAttached/onFrameDetached) and read by user goroutines via
Page.Frames()/Page.Frame() with no synchronization. Frames() also
returned the internal slice without copying, so callers aliased
memory mutated by the event goroutine.

Guard p.frames with the sync.RWMutex already embedded via
channelOwner, mirroring the existing pattern in browser.go and
browser_context.go. Frames() now returns a copy under RLock, Frame()
iterates a locked snapshot, and onFrameAttached/onFrameDetached
mutate under Lock with Emit kept outside the critical section since
handlers run synchronously and may re-enter Page methods.

Adds a regression test that fails with multiple DATA RACE reports
under -race before this change and passes after.

Pull Request Pull Request #625: fix: guard pageImpl.frames to prevent data race

Coverage Stats

8738 of 11097 relevant lines covered (78.74%)

1647.46 hits per line

mxschmitt / playwright-go / 29544834853 / 1
79%
main: 79%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job ubuntu-latest-chromium - 29544834853.1

mxschmitt / playwright-go / 29544834853 / 1 79% main: 79%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job ubuntu-latest-chromium - 29544834853.1

mxschmitt / playwright-go / 29544834853 / 1
79%
main: 79%

README BADGES
x