mxschmitt / playwright-go

78%

Build Type

push

github

Committed by web-flow

Commit Message

test: live CDP download guid coverage and unroute interception deadlock fix (#643)

* test: cover CDP download guid passthrough with a live Chromium session

A Page.enable'd CDPSession plus a real download is what used to kill the
driver connection; keep a browser-level regression next to the unit tests.

Co-authored-by: Max Schmitt <max@schmitt.mx>

* fix: do not hold route mutexes across interception protocol calls

TestContextUnrouteCallShouldStopContextRouteFromHAR hung on WebKit
macOS because onRoute held the context lock while waiting for
setNetworkInterceptionPatterns. Dispatch then blocked in page.onClose
on the same lock, so neither the interception reply nor context.Close
could complete.

Release the lock before the round-trip, and do the same in Route and
Unroute so wait-for-handlers cannot pin the mutex either.

Co-authored-by: Max Schmitt <max@schmitt.mx>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>

Coverage Stats

51 of 55 new or added lines in 2 files covered. (92.73%)

4 existing lines in 3 files now uncovered.

7950 of 10171 relevant lines covered (78.16%)

15816.64 hits per line