NodeBB / NodeBB / 29354700336 / 3

85%

master: 85%

push

github

fix(chats): mark notifications with matching roomId read when opening a room (#14450)

Messaging.markRoomNotificationsRead only matched notifications whose nid
starts with chat_<roomId>_, so chat-related notifications created by
plugins (e.g. message reactions) stayed unread even after the user opened
the room. Topics already handle this by matching unread notifications on
the tid field, and chatsAPI.mark did the same with the roomId field.

Match unread notifications by their roomId field as well, and reuse
markRoomNotificationsRead in chatsAPI.mark instead of duplicating the
logic there.

13224 of 18281 branches covered (72.34%)

27729 of 32666 relevant lines covered (84.89%)

698.52 hits per line