NodeBB / NodeBB / 29354700336

85%

Build Type

push

github

Committed by web-flow

Commit Message

fix(chats): mark notifications with matching roomId read when opening a room (#14450)

Messaging.markRoomNotificationsRead only matched notifications whose nid
starts with chat_<roomId>_, so chat-related notifications created by
plugins (e.g. message reactions) stayed unread even after the user opened
the room. Topics already handle this by matching unread notifications on
the tid field, and chatsAPI.mark did the same with the roomId field.

Match unread notifications by their roomId field as well, and reuse
markRoomNotificationsRead in chatsAPI.mark instead of duplicating the
logic there.

Coverage Stats

14191 of 19327 branches covered (73.43%)

4 of 4 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

29432 of 34453 relevant lines covered (85.43%)

3346.97 hits per line