Freegle / Iznik / 25455 / 25455

73%

master: 73%

push

circleci

fix(migration): logs.subtype enum must match the live DB's physical order

On the live DB 'OurEmailFrequency' was hot-fixed as an END-APPEND, so it
sits at ordinal 47, after 'Repost'. Commit 87afcc2e3 back-filled it into
the create_logs_table migration at position 40 (next to OurPostingStatus),
so every DB built from migrations has had diverged ordinals since. The
add_restored migration (PR #987) was authored from that dev order: on the
live DB its MODIFY is an 8-ordinal reorder, which INSTANT and INPLACE
refuse (error 1846) and only a COPY rebuild of ~40M rows under Galera TOI
can perform - a cluster-wide lock.

- create_logs_table: move OurEmailFrequency to the end, matching live.
- add_restored_to_logs_subtype_enum: list values in the live order so the
  ALTER is a true end-append (INSTANT works); keep the INPLACE fallback
  and add a bare-COPY last resort for dev DBs built from the old order.
  Fix the comment, which claimed the statement was append-only with no
  rebuild.
- Add companion idempotent prod-deploy SQL (INSTANT-only, so any future
  order mismatch fails loudly instead of silently rebuilding).

Validated on percona:8.0.43-34: INSTANT append succeeds on the live order
with row values intact; the old statement is refused by both INSTANT and
INPLACE (1846), confirming the reorder diagnosis; the COPY fallback
remaps by string correctly; the companion SQL is idempotent.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MAMpjuyJgnUSEAsdUcpJr6

574 of 2822 branches covered (20.34%)

Branch coverage included in aggregate %.

355 of 1300 relevant lines covered (27.31%)

13.15 hits per line