kobotoolbox / kpi / 27744015696 / 2

80%

master: 76%

push

github

fix(myLibrary): popover menu items not working 2nd time DEV-2302 (#7163)

### 📣 Summary

Fix issue with My Library "…" ("More actions") dropdown options not
working after trying to use them 2nd time.

### 💭 Notes

Turned out our (now deprecated) `PopoverMenu` component (which has a
very weird complex logic) was misconfigured (again, weird complex logic)
and thus having that weird bug. One liner was all it took to fix it 🤷

An outcome of this bug is me creating a migration task to get rid of
`PopoverMenu`
https://linear.app/kobotoolbox/issue/DEV-2303/migrate-all-popovermenu-instances-to-common-menu

### 👀 Preview steps

1. Go to My Library
2. Create a collection (and end up on collection page)
3. Go back to My Library
4. Hover over new collection and choose "…" ("More actions") → Delete
5. A prompt appears
6. Click "Cancel"
7. Hover over same collection and choose "…" ("More actions") → Delete
8. [on main] 🔴 🐛 Nothing happens
9. [on PR] 🟢 Wow, yay, fixed! 🌈✨💖

4387 of 12156 branches covered (36.09%)

18262 of 36401 relevant lines covered (50.17%)

0.5 hits per line