1
95%
master: 93%

Ran 05 Jun 2026 06:34PM UTC

Files 1128

Run time 36s

Badge

Embed ▾

Committed 05 Jun 2026 06:30PM UTC coverage: 70.336% (+0.7%) from 69.684%

Job # 27032928446.1

Build Type

Pull #2635

github

Committed by

mroderick

Commit Message

fix: safely skip emails to members with invalid addresses

Replace the dangerous mail(mail_args(...)) pattern, which returned nil
for invalid emails and caused NoMethodError crashes in ActionMailer,
with a new mail_to_member helper that returns a SkippedEmail null object.

Changes:
- Add EmailHeaderHelper::SkippedEmail with no-op delivery methods
- Add mail_to_member that validates email before calling mail()
- Migrate all 8 mailers to use mail_to_member
- Guard EmailDelivery#log_sent_email when mail was skipped
- Remove the now-unused mail_args method
- Add skip-path tests for every mailer method

Fixes: https://app.rollbar.com/a/codebar-production/fix/item/codebar-production/690#detail

Pull Request Pull Request #2635: fix: safely skip emails to members with invalid addresses

Coverage Stats

15720 of 22350 relevant lines covered (70.34%)

7.02 hits per line

codebar / planner / 27032928446 / 1
95%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 27032928446.1

codebar / planner / 27032928446 / 1 95% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 27032928446.1

codebar / planner / 27032928446 / 1
95%
master: 93%

README BADGES
x