codebar / planner / 27032928446

95%

master: 93%

Pull #2635

github

fix: safely skip emails to members with invalid addresses

Replace the dangerous mail(mail_args(...)) pattern, which returned nil
for invalid emails and caused NoMethodError crashes in ActionMailer,
with a new mail_to_member helper that returns a SkippedEmail null object.

Changes:
- Add EmailHeaderHelper::SkippedEmail with no-op delivery methods
- Add mail_to_member that validates email before calling mail()
- Migrate all 8 mailers to use mail_to_member
- Guard EmailDelivery#log_sent_email when mail was skipped
- Remove the now-unused mail_args method
- Add skip-path tests for every mailer method

Fixes: https://app.rollbar.com/a/codebar-production/fix/item/codebar-production/690#detail

36 of 36 new or added lines in 9 files covered. (100.0%)

3551 of 3725 relevant lines covered (95.33%)

42.11 hits per line