kobotoolbox / kpi / 26967058193 / 9

82%

master: 76%

push

github

feat(map): improve settings modal tabs logic DEV-2224 (#7117)

### 📣 Summary

Map display settings modal now has a consistent and tested tab display
behaviour. The order of the tabs is now enforced and kept the same.

### 💭 Notes

Changes here:
- jsapp/js/components/map/MapSettings.tsx: 
- Extracted tab visibility rules into buildMapSettingsTabsToDisplay to
keep tab logic in one place.
- Stabilized tab rendering with tab-id keys and active-tab fallback when
needed.
  - Default active tab is now always Colors.
- jsapp/js/components/map/MapSettings.tests.ts: 
- Added unit tests for tab composition across combinations (baseline,
query limit, multiple geopoints, both together, and read-only case).

Tiny map pun for morale from AI: no tabs were harmed in this navigation.

### 👀 Preview steps

Please verify that tab appearance is working correctly:
1. "Marker Colors" - always there
2. "Query Limit" - if more than 1000 submissions
3. "Geopoint question" - whether has at least 2 `geopoint` type question
4. "Overlays" - user has `change_asset` permission

5908 of 12166 branches covered (48.56%)

21910 of 36165 relevant lines covered (60.58%)

0.61 hits per line