MushroomObserver / mushroom-observer / 26904612251 / 1
97%
main: 97%

DEFAULT BRANCH: main
Ran
Files 1353
Run time 37s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.962% (+0.02%) from 96.945%
26904612251.1

push

github

web-flow 
Tab POROs: sweep observations/names/locations adapter callers (#4429)

* Tab POROs: sweep callers off observations/names/locations adapter helpers

`app/helpers/tabs/{observations,names,locations}_helper.rb` were left
as thin legacy-shape adapters (`*_tab(s)` → `Tab::*.new(...).to_a`)
after the original PORO migrations (#4413, #4411, #4412). This sweep
moves every caller off those adapters onto the POROs directly:

- ~30 ERB views + 4 inline single-tab call sites swept across
  observations, names, and locations show / form / index / map /
  versions / namings / synonyms / classification / lifeforms /
  trackers / species-lists pages
- `add_context_nav(*_tabs(...))` → `add_context_nav(Tab::*.new(...))`
- `icon_link_to(*single_tab(...))` →
  `icon_link_to(*Tab::*.new(...).to_a)`
- Guarded single-tab helpers (`*_synonym_form_tab`,
  `*_description_tab`, `name_tracker_form_tab`,
  `observation_manage_lists_tab`) inlined at the call site so the
  guard logic stays visible
- `Components::Base#register_value_helper :send_observer_question_tab`
  registration dropped (no Phlex callers remain)
- `tabs/observations_helper.rb` rewritten to retain only the HTML
  composers (`name_links_on_mo`, `user_name_links_web`,
  `obs_name_description_tabs`, which depend on
  `descriptions_helper#list_descriptions`) and the non-tab
  utilities (titles + sorts + print labels button). The two
  composers that survive now call the POROs directly.
- `tabs/names_helper.rb` rewritten to retain only the external link
  tabs (`external_name_tab` + the per-site helpers using it) and
  `names_index_sorts`
- `tabs/locations_helper.rb` rewritten to retain only
  `locations_index_sorts`

Follow-up: relocate the surviving methods from each
`tabs/*_helper.rb` to the corresponding `app/helpers/*_helper.rb`,
then delete the empty `tabs/*` files and the
`config/initializers/phlex.rb` `to_prepare` auto-include of those
modules into `Views::Base`. Out of scope for this PR — would also
need `de... (continued)

42132 of 43452 relevant lines covered (96.96%)

683.66 hits per line

Source Files on job 26904612251.1