ruby-grape / grape / 26340504005 / 27

97%

master: 97%

Pull #2741

github

Readability pass: guard clauses, small refactors across lib/

Mostly cosmetic, no behavior change except where noted.

Guard-clause lifts (lift the short-circuit above the if/elsif/else,
let the main flow sit at top indentation):

- `Grape::DSL::Logger#logger`, `DSL::InsideRoute#stream`/`#return_no_content`
- `Grape::Formatter::SerializableHash#serialize`
- `Grape::Middleware::Base#merge_default_options`
- `Grape::Middleware::Error#redispatch`
- `Grape::Middleware::Formatter` (`call!`, `negotiate_content_type`)
- `Grape::Router::Pattern#build_path_from_pattern`
- `Grape::ServeStream::SendfileResponse#respond_to?`
- `Grape::Validations::ParamsScope#configure_declared_params`
- `Grape::Exceptions::ErrorResponse.coerce` (case/when reformatted)

Small extractions:

- `DSL::Entity#entity_class_for_obj`: extract `object_class(object)`
  private helper.
- `DSL::InsideRoute#status`: collapse Symbol/Integer branches and
  extract `default_status` private helper. Error message for an
  unknown status symbol now bubbles up `Rack::Utils.status_code`'s
  own message ("Unrecognized status code :foo_bar") instead of
  Grape's pre-validation message ("Status code :foo_bar is invalid.");
  spec updated.
- `DSL::InsideRoute#stream`: extract `stream_body(value)` private
  helper.
- `DSL::InsideRoute#return_no_content`: drop the redundant `status 204`
  call — `body false` already sets it via the `body` setter.

Minor: `return nil unless` → `return unless` in `Grape::API::Boolean.build`
and `PrimitiveCoercer#call`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

243 of 1165 branches covered (20.86%)

Branch coverage included in aggregate %.

2378 of 3565 relevant lines covered (66.7%)

10.88 hits per line