kobotoolbox / kpi / 26116545456 / 3

82%

master: 76%

push

github

refactor(dataTable): move around and group cell related files DEV-2119 (#7052)

### 💭 Notes

This PR is a refactor only. No behavior change is intended. It mostly
moves furniture around without changing the house.

Changes here:
- `jsapp/js/components/submissions/table.tsx`
- extracts the large inline `Cell` renderer into a dedicated
`DataTableCell` component
- keeps column setup and table orchestration in `table.tsx`, so the
render path is easier to follow
- `jsapp/js/components/submissions/DataTableCell/index.tsx`
  - becomes the new entry point for table cell rendering
- keeps the same rendering logic for repeat groups, media, audio, text
modal cells, select labels, and supplemental details
  - simplifies props a bit:
- renames `row` to `reactTableRow` to make it clear this comes from
`react-table`
- derives the select-multiple label flag locally instead of passing it
down
- `jsapp/js/components/submissions/DataTableCell/*`
- moves the cell-only helper components into the same folder as private
implementation details:
    - `AudioCell`
    - `MediaCell`
    - `RepeatGroupCell`
    - `TextModalCell`
- renames moved files to PascalCase to match the usual naming guideline
  - moves the related styles along with those components

Why this split:
- it makes the upcoming bulk-processing cell work easier to review
- it narrows the future DEV-1407 changes to the cell module instead of
another pass through the large table component

What to pay extra attention to in review:
- audio cells still open Processing as before
- image/video/file cells still open the media modal as before
- repeat group answers still render inline
- text and supplemental detail cells still open the text modal as before

### 👀 Preview steps

1. Open a project with all question types and submission that replies to
all questions.
2. Go to `Project → Data → Table`.
3. Verify that table displays all responses correctly
4. Open a long text cell and confirm the modal still opens and shows ... (continued)

4828 of 12324 branches covered (39.18%)

19719 of 37096 relevant lines covered (53.16%)

0.53 hits per line