ruby-grape / grape / 25862770726 / 8

97%

master: 97%

Pull #2716

github

Refactor DSL::Routing#version: guard clause + explicit kwargs

Two changes that touch the same method:

1. Lift the body out of `if args.any? ... end` into a
   `return @versions&.last if args.empty?` guard, so the main flow sits
   at top indentation instead of one level inside an `if`.

2. Replace `**options` with explicit kwargs `(using:, cascade:,
   parameter:, strict:, vendor:)` and bake the defaults into the
   signature (matching `Versioner::Base::DEFAULT_OPTIONS`). The
   per-call `reverse_merge(using: :path)` is gone, and
   `version_options` now stores a fully-resolved hash instead of a
   sparse one. `Versioner::Base::DEFAULT_OPTIONS` is left untouched so
   anyone mounting the middleware directly (some middleware specs do)
   still gets the same safe defaults.

`version_options` is read for exactly these five keys across the
codebase, and nothing else: `:using` (endpoint.rb, path.rb), and
`:cascade`/`:parameter`/`:strict`/`:vendor` (Versioner::Base#initialize,
plus `:cascade` in API::Instance#cascade?). Any other kwarg passed to
`.version` was previously swallowed by the splat with no effect.

Spec fixtures that passed `format:` to `.version` are updated:

- `spec/shared/versioning_examples.rb`: `**macro_options` →
  `**macro_options.except(:format)` at the 14 call sites. `:format`
  stays in `macro_options` so the test helper (`versioned_helpers.rb`)
  can still build the `HTTP_ACCEPT` header.
- `spec/grape/exceptions/invalid_accept_header_spec.rb`: drop
  `format: :json` from 8 direct `.version` calls (it was never read
  on the lib side, and these tests build their Accept header inline).
- `spec/grape/dsl/routing_spec.rb`: the `:version_options` assertion
  now expects the full resolved hash.

No production behaviour change beyond `.version` raising
`ArgumentError` for genuinely unknown kwargs (previously silently
ignored).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1051 of 1159 branches covered (90.68%)

Branch coverage included in aggregate %.

3424 of 3516 relevant lines covered (97.38%)

1005.19 hits per line