IJHack / QtPass / 25793206586 / 1
55%
main: 55%

DEFAULT BRANCH: main
Ran
Files 72
Run time 4s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 29.083% (+0.1%) from 28.988%
25793206586.1

push

github

web-flow 
test: cover SSH_AUTH_SOCK override soft-validation via Util helper (#1469)

The Settings dialog warning logic added in #1439 (configdialog.cpp
on_accepted) had no unit tests. Extract the validation rules into a
pure helper so they're testable without a Qt event loop or
QMessageBox spy.

Production change (mechanical, no semantic diff):

- New Util::sshAuthSockOverrideStatus(QString) returning an enum:
  Valid / DoesNotExist / NotReadable / NotUnixDomainSocket. Same three
  checks as before (exists, readable, S_ISSOCK on Unix), now reusable
  and unit-testable.
- ConfigDialog::on_accepted switches the three inline if/else branches
  to a switch over the enum. Translation strings stay in ConfigDialog
  (Util has no tr() callers).
- Dropped now-unused #include <QFileInfo> and #include <sys/stat.h>
  from configdialog.cpp.

Tests (tst_util.cpp):

- sshAuthSockOverrideStatusDoesNotExist — non-existent path
- sshAuthSockOverrideStatusRegularFileRejected — regular file (Unix)
- sshAuthSockOverrideStatusNotReadable — chmod 0 (Unix; skipped under
  root since euid 0 ignores mode bits)
- sshAuthSockOverrideStatusValid — bind(2) a real Unix domain socket
  and assert Valid

POSIX socket(2)/bind(2) instead of QLocalServer to avoid pulling
QtNetwork into the util test target. Unix-only tests SKIP on Windows
where the production code also skips the socket check (ssh-agent uses
a named pipe there).

Build clean, 124/124 util tests pass (was 120, +4).

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

1957 of 6729 relevant lines covered (29.08%)

27.09 hits per line

Source Files on job 25793206586.1