graphql-go / graphql / 1902 / 1
86%
master: 92%

LAST BUILD BRANCH: cycle-guard
DEFAULT BRANCH: master
Ran
Files 44
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.711% (-8.6%) from 92.284%
1902.1

Pull #740

circleci

Nthalk 
refactor: remove dead executor code superseded by Plan/ExecutePlan

Execute now routes unconditionally through PlanQuery + ExecutePlan
(see plan.go), so the entire pre-refactor execution machinery in
executor.go is unreachable. Delete it:

  executeOperation / executeOperationParams
  executeFieldsSerially / executeFields / executeSubFields / executeFieldsParams
  resolveField / resolveFieldResultState
  completeValueCatchingError / completeValue
  completeThunkValueCatchingError
  completeAbstractValue / completeObjectValue / completeListValue
  orderedField / orderedFields

Each has a 1:1 plan-based replacement in plan.go (executePlannedSelection,
resolvePlannedField, completePlannedValue family, etc.); plan.fields
is source-ordered at plan time so orderedFields is no longer needed.

Kept (still has live callers):
  Execute, buildExecutionContext, collectFields, getFieldDef,
  handleFieldError, DefaultResolveFn, defaultResolveTypeFn,
  completeLeafValue, getOperationRootType, dethunk* helpers,
  shouldIncludeNode, doesFragmentConditionMatch, getFieldEntryKey.

Subscriptions still go through buildExecutionContext + collectFields +
manual resolver invocation in subscription.go; that path is untouched.

-450 lines. Root-package coverage: 84.2% → 88.4%.
Pull Request #740: Plan + PlanQuery + ExecutePlan + PlanCache (cacheable execution shape)

9538 of 11394 relevant lines covered (83.71%)

1115.31 hits per line

Source Files on job 1902.1