graphql-go / graphql / 1902

86%

master: 92%

Build Type

Pull #740

circleci

Committed by Nthalk

Commit Message

refactor: remove dead executor code superseded by Plan/ExecutePlan

Execute now routes unconditionally through PlanQuery + ExecutePlan
(see plan.go), so the entire pre-refactor execution machinery in
executor.go is unreachable. Delete it:

  executeOperation / executeOperationParams
  executeFieldsSerially / executeFields / executeSubFields / executeFieldsParams
  resolveField / resolveFieldResultState
  completeValueCatchingError / completeValue
  completeThunkValueCatchingError
  completeAbstractValue / completeObjectValue / completeListValue
  orderedField / orderedFields

Each has a 1:1 plan-based replacement in plan.go (executePlannedSelection,
resolvePlannedField, completePlannedValue family, etc.); plan.fields
is source-ordered at plan time so orderedFields is no longer needed.

Kept (still has live callers):
  Execute, buildExecutionContext, collectFields, getFieldDef,
  handleFieldError, DefaultResolveFn, defaultResolveTypeFn,
  completeLeafValue, getOperationRootType, dethunk* helpers,
  shouldIncludeNode, doesFragmentConditionMatch, getFieldEntryKey.

Subscriptions still go through buildExecutionContext + collectFields +
manual resolver invocation in subscription.go; that path is untouched.

-450 lines. Root-package coverage: 84.2% → 88.4%.

Pull Request Pull Request #740: Plan + PlanQuery + ExecutePlan + PlanCache (cacheable execution shape)

Coverage Stats

832 of 1063 new or added lines in 4 files covered. (78.27%)

97 existing lines in 1 file now uncovered.

9538 of 11394 relevant lines covered (83.71%)

1115.31 hits per line