IJHack / QtPass / 25580803246 / 1
55%
main: 55%

DEFAULT BRANCH: main
Ran
Files 72
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 28.034% (-0.002%) from 28.036%
25580803246.1

push

github

web-flow 
refactor: 6 reviewer cleanups in util.cpp + qtpass.cpp (#1436)

util.cpp (5 fixes):

- Tilde-expansion comment: noted the limitation that "~username"
  forms are intentionally not resolved (only "~" / "~/...").
- PATH delimiter: replaced runtime check
  (QDir::separator() == '\\' ? ';' : ':') with explicit
  #ifdef Q_OS_WIN block. Clearer intent, no Q-API call needed.
- findBinaryInPath whitespace test: dropped the static
  QRegularExpression in favour of std::any_of with
  QChar::isSpace(). Same Unicode coverage, no regex compile cost.
- findBinaryInPath WSL fallback: cache results in a static
  QHash<QString, QString>. The "wsl <binary> --version" probe is
  a blocking subprocess; without caching it ran once per call
  for any binary not on PATH.
- configIsValid WSL probe: wrap in a lambda-initialised static
  const bool — same caching reasoning. WSL availability doesn't
  change at runtime.

qtpass.cpp (1 fix):

- aboutToQuit connect: the existing GCC/clang #pragma deprecation
  suppression doesn't compile on MSVC. Added the MSVC variant
  (#pragma warning(push) / disable : 4996 / pop) under
  defined(_MSC_VER), with the GCC/clang block as the elif branch.

Skipped one reviewer finding (qtpass.cpp dwordBytes "missing
definition" — already defined in qtpass.h:29 as static inline,
visible at every call site through the existing #include).

Validation:
- tst_util: 106/106 pass.
- clang-tidy: 0 findings on touched files.
- clang-format clean.
- Build clean.

1855 of 6617 relevant lines covered (28.03%)

27.11 hits per line

Source Files on job 25580803246.1