lsm / neokai / 25478119736 / 21

83%

dev: 83%

push

github

fix: make settingSources configurable so CLAUDE.md loads again (#1816)

* fix: make settingSources configurable so CLAUDE.md loads again

- Default settingSources to ['user', 'project'] (was hardcoded [])
- Keep strictMcpConfig: true unconditional (MCP stays locked to registry)
- Add setting_sources columns to spaces and space_agents (migrations 118/119)
- Thread settingSources through AgentSessionInit → SessionConfig → QueryOptionsBuilder
- Allow per-session, per-space, per-agent, and global UI configuration
- Update test schemas and expectations to match new default

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Include 'local' in default settingSources; preserve inheritance semantics

- DEFAULT_GLOBAL_SETTINGS.settingSources now includes 'local' so all three
  sources are loaded by default.
- Updated fallback values across UI components (GeneralSettings, SpaceSettings,
  SpaceAgentEditor, ToolsModal) and daemon comments/tests.
- SpaceSettings and SpaceAgentEditor only persist settingSources when the
  entity originally had an explicit value or the user touched the checkboxes,
  preventing inherited defaults from being silently converted into hardcoded
  overrides.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Wire tools and settingSources through space agent RPC handlers

- spaceAgent.create and spaceAgent.update handlers now forward `tools`
  and `settingSources` from the RPC payload to SpaceAgentManager,
  making the SpaceAgentEditor's tool and setting-sources UI functional.
- Updated stale comments in settings-manager.ts and query-options-builder.ts
  that incorrectly claimed settingSources was unconditionally [].

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* Preserve inheritance for new agents and allow empty settingSources

- SpaceAgentEditor no longer forces settingSources into the create payload
  when the user hasn't touched the checkboxes. New agents now inherit from
  space/global defaults by defau... (continued)

8230 of 11408 branches covered (72.14%)

Branch coverage included in aggregate %.

10678 of 13146 relevant lines covered (81.23%)

56.01 hits per line