• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ForumMagnum / ForumMagnum / 25464730841 / 1
48%
master: 47%

Build:
Build:
LAST BUILD BRANCH: ea-deploy
DEFAULT BRANCH: master
Ran 06 May 2026 10:32PM UTC
Files 2802
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

06 May 2026 10:29PM UTC coverage: 34.182% (+0.02%) from 34.159%
25464730841.1

Pull #12497

github

claude
Revert redundant rejected filters in getCommentsWithReacts and getRecentCommentsOnPosts

Two more places where the original "rejected" filter I added isn't doing
useful work:

- getCommentsWithReacts: not used on EA Forum at all. The query also
  doesn't filter deleted/retracted/spam, so a rejected-only filter was
  asymmetric anyway. Drop the change (and the inner-subquery JOIN to
  Comments that I added to make LIMIT honor it).

- getRecentCommentsOnPosts: the caller in lib/collections/posts/helpers.ts
  builds its filter starting with getDefaultViewSelector("Comments"), which
  already includes rejected/deleted/draft handling and is then compiled
  into the SQL via SelectQuery. The hardcoded "rejected" IS NOT TRUE clause
  I added was redundant with the compiled filter. Same flavor of mistake
  as the bulk-indexer fix: half-implementing a backstop pattern at a layer
  that doesn't need it. If a future caller passes a filter without the
  default view, the fix belongs at that call site.
Pull Request #12497: Filter rejected content from shared queries and clean up notifications

4802 of 6711 branches covered (71.55%)

Branch coverage included in aggregate %.

125033 of 373119 relevant lines covered (33.51%)

34.63 hits per line

Source Files on job Integration - 25464730841.1
  • Tree
  • List 2802
  • Changed 24
  • Source Changed 18
  • Coverage Changed 19
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Build 25464730841
  • 6d589f4e on github
  • Prev Job for on claude/rejected-content-investigation-0WkBz (#25456600642.2)
  • Next Job for on claude/rejected-content-investigation-0WkBz (#25467297191.2)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc