ForumMagnum / ForumMagnum / 25464730841

48%

master: 47%

Build Type

Pull #12497

github

Committed by claude

Commit Message

Revert redundant rejected filters in getCommentsWithReacts and getRecentCommentsOnPosts

Two more places where the original "rejected" filter I added isn't doing
useful work:

- getCommentsWithReacts: not used on EA Forum at all. The query also
  doesn't filter deleted/retracted/spam, so a rejected-only filter was
  asymmetric anyway. Drop the change (and the inner-subquery JOIN to
  Comments that I added to make LIMIT honor it).

- getRecentCommentsOnPosts: the caller in lib/collections/posts/helpers.ts
  builds its filter starting with getDefaultViewSelector("Comments"), which
  already includes rejected/deleted/draft handling and is then compiled
  into the SQL via SelectQuery. The hardcoded "rejected" IS NOT TRUE clause
  I added was redundant with the compiled filter. Same flavor of mistake
  as the bulk-indexer fix: half-implementing a backstop pattern at a layer
  that doesn't need it. If a future caller passes a filter without the
  default view, the fix belongs at that call site.

Pull Request Pull Request #12497: Filter rejected content from shared queries and clean up notifications

Coverage Stats

7926 of 10717 branches covered (73.96%)

Branch coverage included in aggregate %.

29 of 36 new or added lines in 9 files covered. (80.56%)

92 existing lines in 6 files now uncovered.

177794 of 373125 relevant lines covered (47.65%)

36.56 hits per line