MushroomObserver / mushroom-observer / 25340353167 / 1
96%
main: 96%

LAST BUILD BRANCH: nimmo-project-forms-radio-field
DEFAULT BRANCH: main
Ran
Files 989
Run time 29s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.38% (-0.002%) from 96.382%
25340353167.1

Pull #4204

github

mo-nathan 
Keep synonym-only-observed targets in Unobserved (Fixes #4152)

When a project target's name has no direct observation but a
synonym does, the previous logic merged the target into the
"Species and below" panel with a "(0)" count and a link that
filtered observations on the target's name only — producing an
empty list. The behavior was confusing: the row claimed the
target was observed but the link said otherwise.

This change:

* Drops the synonym-aware merge into @taxa. A target now appears
  in @taxa (and the Species/higher panels) only when the project
  has at least one observation whose consensus name *is* the
  target name.
* Keeps the synonym-only-observed target in `unobserved_target_taxa`,
  where the panel renders a Name show-page link as it does for
  every other unobserved target.
* The `+` marker still fires on both the target row (in Unobserved)
  and the synonym row (in Species and below). `recompute_rendered_
  taxa_flags` already computes `duplicate_synonyms` across both
  panels, so no marker logic changes.
* `num_targets_observed` now counts direct-only matches. The
  summary line `"X total targets, Y observed, Z unobserved"`
  reflects what's in the panels and nudges admins to re-identify
  observations to the project's target names rather than letting
  synonyms silently satisfy them.

Updates `test_num_targets_observed_via_synonym` (was asserting the
old synonym-aware count) and adds a test for the edge case where
both names of a synonym pair are project targets.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Pull Request #4204: Keep synonym-only-observed targets in Unobserved (Fixes #4152)

38231 of 39667 relevant lines covered (96.38%)

657.07 hits per line

Source Files on job 25340353167.1