kobotoolbox / kpi / 24985384679 / 1

82%

master: 76%

push

github

fix(constance): remove environment variable fallbacks from Google NLP Constance settings DEV-2017 (#6965)

### 📖 Description
We previously introduced `CONSTANCE_`-prefixed environment variable
fallbacks (using `env.str()`) for the Google NLP settings
(`ASR_MT_GOOGLE_*`) within the `CONSTANCE_CONFIG` dictionary in
`base.py` ([#6933](https://github.com/kobotoolbox/kpi/pull/6933)).

The Sysadmin team has since identified that injecting these
configurations especially complex JSON credentials via environment
variables leads to escaping issues in Kubernetes deployments.

To improve stability and security, the team is transitioning to securely
mounted files (e.g., Kubernetes Secrets) and relying on native Google
library mechanisms (such as the `GOOGLE_APPLICATION_CREDENTIALS`
environment variable) for NLP authentication and configuration.

This PR removes the custom environment variable fallback logic from the
codebase.

The following four settings in base.py have been reverted to their
original values to support this pattern:
* `CONSTANCE_ASR_MT_GOOGLE_PROJECT_ID` →`'kobo-asr-mt'`
* `CONSTANCE_ASR_MT_GOOGLE_STORAGE_BUCKET_PREFIX` →`'kobo-asr-mt-tmp'`
* `CONSTANCE_ASR_MT_GOOGLE_TRANSLATION_LOCATION` →`'us-central1'`
* `CONSTANCE_ASR_MT_GOOGLE_CREDENTIALS` → `""`

3560 of 11830 branches covered (30.09%)

18948 of 35943 relevant lines covered (52.72%)

0.53 hits per line