IJHack / QtPass / 24888772601 / 1
55%
main: 55%

DEFAULT BRANCH: main
Ran
Files 64
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 26.828%. Remained the same
24888772601.1

push

github

web-flow 
fix: address Copilot review findings (round 2) (#1151)

* fix: address Copilot review findings (round 2)

src/pass.cpp:
- Add Doxygen blocks to anonymous-namespace helpers fallbackCharset,
  effectiveCharset, resolveWslGpgconfPath, containsAny, and
  isGrepHeaderLine, matching the style of containsAnyCaseInsensitive
  in the same translation unit.

tests/auto/settings/tst_settings.cpp:
- Expand the non-portable-mode warning to spell out that QSettings
  writes to per-user storage (e.g. the Windows registry) when no
  qtpass.ini sits next to the binary, and how to opt into portable
  mode for an isolated run.
- Add an inline comment explaining why boolRoundTrip uses !testValue
  as the getter's default — a missing/unstored value would otherwise
  silently equal testValue and pass the assertion.

Rejected findings:
- Changing s.getter(!testValue) → s.getter(false) would weaken the
  test: when testValue is false, an unstored setting would still
  satisfy the equality and the test would pass without writing.
- Asserting QStringLiteral("false") on round-tripped useGit/autoPush/
  autoPull values would fail — setProfiles writes empty strings for
  keys that aren't present on the input hash, and the test only
  populates "path".

* fix: apply CodeRabbit auto-fixes

Fixed 1 file(s) based on 1 unresolved review comment.

Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

---------

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: CodeRabbit <noreply@coderabbit.ai>

1640 of 6113 relevant lines covered (26.83%)

28.94 hits per line

Source Files on job 24888772601.1