kobotoolbox / kpi / 24820506875 / 8

82%

master: 76%

push

github

fix(connectProjects): unhelpful error message DEV-1435 (#6956)

### 📣 Summary

Provides a helpful error message with a list of invalid fields when
using Project → Settings → Connect Projects.

### 💭 Notes

Changes here:
- `ServerError.ts` now returns complete response as `parsedResponse`
(not only the `details` part), thus making it possible to access
`fields` in error response
- `ConnectProjects` and `DataAttachmentColumnsForm` components now uses
custom error handling
- `dataAttachmentUtils.ts` has now a
`extractInvalidFieldsFromResponseMessage` function that extracts the
fields from the error response (plus a simple unit tests) and
`buildInvalidFieldsErrorMessage` for keeping things DRY

### 👀 Preview steps

Use test form file and steps from Linear task
https://linear.app/kobotoolbox/issue/DEV-1435/error-when-linking-forms-new-form-to-itself-using-dda

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

4772 of 11963 branches covered (39.89%)

22198 of 36126 relevant lines covered (61.45%)

0.61 hits per line