Freegle / Iznik / 5227 / 5227

72%

master: 72%

push

circleci

fix(ads): allow clicks on Jobs and static ads once ad renders (#222)

Commit ba725baeb switched ExternalDa.vue's `passClicks` from a boolean
(silently-invalid CSS that always fell back to `auto`) to concrete
`'none'`/`'auto'` values but kept the same ternary direction, which
inverted the effective behaviour: once an ad/fallback resolved
(`adShown=true`), the container got `pointer-events: none` and blocked
clicks on Jobs links and static banner ads (Utility Warehouse, Temu,
etc.). Video ads were unaffected because they float above the container.

Flip the mapping so the rendered ad or fallback slot is clickable and
the empty placeholder is click-transparent, and update the existing
tests to codify the corrected contract.

Reported on Discourse #9481 posts 492/493.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

4494 of 10164 branches covered (44.21%)

Branch coverage included in aggregate %.

2035 of 4232 relevant lines covered (48.09%)

79.73 hits per line