kobotoolbox / kpi / 24652083072 / 7

82%

master: 76%

push

github

fix: prevent IntegrityError when running `create_kobo_superuser` management command DEV-1987 (#6945)

### 📣 Summary

Running `create_kobo_superuser` could crash with an `IntegrityError`
when trying to create the user profile.

### 💭 Notes

- `UserProfile.objects.create` and `EmailAddress.create` replaced with
`get_or_create` to avoid `IntegrityError` on duplicate records.
- Secondary fix: when `ProgrammingError` is raised inside
`create_superuser` (KC DB not ready, signal-level failure), the `user`
variable was never assigned, causing a `NameError` on the subsequent
`EmailAddress.objects.get_or_create(user=user, ...)` call. Fix: retrieve
the already-saved user via `User.objects.get(username=super_username)`.
- Three unit tests added: happy path, `ProgrammingError` recovery
(mocked), and early-exit when user already exists.

### Preview steps:
1. from release branch, run `KOBO_SUPERUSER_USERNAME=foobar ./manage.py
create_kobo_superuser` and receive an IntegrityError
2. from this branch, receive the message "Superuser xxx successfully
created."

5344 of 11937 branches covered (44.77%)

23784 of 36014 relevant lines covered (66.04%)

0.66 hits per line