kobotoolbox / kpi / 23645386270 / 2

82%

master: 76%

push

github

fix(qual): do not allow deleting all choices DEV-1914 (#6873)

### 📣 Summary
Forbid users from deleting all choices in a multiple choice QA question

### 💭 Notes
Enforced at the schema level, with extra protection for prompt
generation in case somehow a bad configuration makes it into the
database.


### 👀 Preview steps

1. ℹ️ have an account and a project with an audio question and at least
one submission
2. Add a QA question to create the manual_qual advanced feature
3. PATCH the correct `manual_qual` advanced feature object with
```
{"params": [{
     "uuid": "e091ee38-a46d-4ca5-adc9-1ccc158b938a",
     "labels": {"_default": "Question"},
     "type": "qualSelectOne",
     "choices": [{"labels": {"_default": "choiceA"},
             "uuid":"541cc55e-6e91-4c0f-b355-9c81b3dbff66",
             "options": {"deleted": true} }]
}]}
```
5. 🔴 [on main] request succeeds and all options are deleted
6. 🟢 [on PR] validation error

3882 of 11824 branches covered (32.83%)

19525 of 35901 relevant lines covered (54.39%)

0.54 hits per line