shader-slang / slang-rhi / 23336160341 / 3

69%

main: 69%

push

github

Add AccelerationStructureKind to AccelerationStructureDesc (#694)

* Add AccelerationStructureKind to AccelerationStructureDesc and fix Vulkan AS creation type

Vulkan GPU-assisted validation enforces VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-12281,
which requires that acceleration structures referenced as BLAS instances must have been created
with VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR, not VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.

The Vulkan backend was previously always creating acceleration structures with GENERIC_KHR,
which was caught by the new GPU-AV test added in PR #622.

Fix by adding AccelerationStructureKind enum (Unknown/BottomLevel/TopLevel) and a kind field
to AccelerationStructureDesc. The Vulkan backend now maps kind to the correct
VkAccelerationStructureTypeKHR at creation time (defaulting to GENERIC_KHR for Unknown,
preserving backward compatibility). All tests are updated to set the correct kind.

* Add enumToString for AccelerationStructureKind

* Check for valid AccelerationStructureKind

* Add IAccelerationStructure::getDesc()

* Add kind to default acceleration structure label

* Cleanup

* Additional validation

* Remove vulkan comment

* Cleanup

---------

Co-authored-by: Simon Kallweit <skallweit@nvidia.com>

7592 of 13740 branches covered (55.25%)

Branch coverage included in aggregate %.

22252 of 32716 relevant lines covered (68.02%)

138984.82 hits per line