shader-slang / slang-rhi / 23336160341

68%

Build Type

push

github

Committed by web-flow

Commit Message

Add AccelerationStructureKind to AccelerationStructureDesc (#694)

* Add AccelerationStructureKind to AccelerationStructureDesc and fix Vulkan AS creation type

Vulkan GPU-assisted validation enforces VUID-vkCmdBuildAccelerationStructuresKHR-pInfos-12281,
which requires that acceleration structures referenced as BLAS instances must have been created
with VK_ACCELERATION_STRUCTURE_TYPE_BOTTOM_LEVEL_KHR, not VK_ACCELERATION_STRUCTURE_TYPE_GENERIC_KHR.

The Vulkan backend was previously always creating acceleration structures with GENERIC_KHR,
which was caught by the new GPU-AV test added in PR #622.

Fix by adding AccelerationStructureKind enum (Unknown/BottomLevel/TopLevel) and a kind field
to AccelerationStructureDesc. The Vulkan backend now maps kind to the correct
VkAccelerationStructureTypeKHR at creation time (defaulting to GENERIC_KHR for Unknown,
preserving backward compatibility). All tests are updated to set the correct kind.

* Add enumToString for AccelerationStructureKind

* Check for valid AccelerationStructureKind

* Add IAccelerationStructure::getDesc()

* Add kind to default acceleration structure label

* Cleanup

* Additional validation

* Remove vulkan comment

* Cleanup

---------

Co-authored-by: Simon Kallweit <skallweit@nvidia.com>

Run Details

11947 of 20302 branches covered (58.85%)

Branch coverage included in aggregate %.

52 of 62 new or added lines in 10 files covered. (83.87%)

18 existing lines in 5 files now uncovered.

35259 of 47890 relevant lines covered (73.62%)

281811.2 hits per line