RobotWebTools / rclnodejs / 22699741741 / 1

86%

develop: 86%

push

github

Evaluate error message before resetting error state in macros (#1406)

This PR adjusts the ROS error-state reset behavior in the C++/N-API helper macros so the error message can be captured before the global RCL error state is cleared, improving the fidelity of JavaScript exceptions thrown from native bindings.

**Changes:**
- Move `rcl_reset_error()` to occur *after* `Napi::Error::New(...).ThrowAsJavaScriptException()` in `CHECK_OP_AND_THROW_ERROR_IF_NOT_TRUE`.
- Apply the same ordering fix to the `_NO_RETURN` variant.

Fix: #1405

1380 of 1755 branches covered (78.63%)

Branch coverage included in aggregate %.

2859 of 3204 relevant lines covered (89.23%)

449.81 hits per line