zwave-js / zwave-js-ui / 22675228637 / 1

18%

master: 18%

push

github

fix(ui): show "unknown" for null/undefined values with units; fix battery level null display (#4569)

When a non-compliant device responds to a battery level request with
only a "battery low" notification, `minBatteryLevel` ends up as `null`.
Two bugs compound: JS coerces `null` to `0` in numeric comparisons
(`null <= 10 === true`), causing the battery column to show `"null%"`
with a red error icon; and `ValueId.vue`'s readonly display concatenates
the unit unconditionally, producing `"null %"` or `"undefined %"`.

## Changes

- **`ValueId.vue`** — Guard the readonly display expression: if
`parsedValue == null`, render `"unknown"` instead of `parsedValue + '
<unit>'`.

  ```diff
  - parsedValue + (modelValue.unit ? ' ' + modelValue.unit : '')
  + parsedValue == null
  +   ? 'unknown'
  +   : parsedValue + (modelValue.unit ? ' ' + modelValue.unit : '')
  ```

- **`nodes-table.js` / `SmartView.vue`** — In `powerRichValue`, add an
explicit `level == null` guard before the numeric `if`/`else if` chain.
When null/undefined: show the battery-unknown icon, set `description =
'Battery level: unknown'`, and leave `label` empty (no text in the
battery column). Also removed the now-unreachable `else` branch that
previously followed `level > 90`.

<!-- START COPILOT ORIGINAL PROMPT -->



<details>

<summary>Original prompt</summary>

> 
> ----
> 
> *This section details on the original issue you should resolve*
> 
> <issue_title>Battery level reported as above 100% (e.g. 247%, 254%)
for low battery condition</issue_title>
> <issue_description>### Checklist
> 
> - [x] I am not using Home Assistant. Or: a developer has told me to
come here.
> - [x] I have checked the troubleshooting section and my problem is not
described there.
> - [x] I have read the changelog and my problem is not mentioned there.
> 
> ### Deploy method
> 
> Snap
> 
> ### Z-Wave JS UI version
> 
> 11.4.1
> 
> ### ZwaveJS version
> 
> 15.15.3
> 
> ### Describe the bug
> 
> For battery-operated d... (continued)

334 of 444 branches covered (75.23%)

Branch coverage included in aggregate %.

4052 of 22582 relevant lines covered (17.94%)

1.12 hits per line