kobotoolbox / kpi / 21689084050 / 1

82%

master: 76%

push

github

build(docker): build node app in a separate docker build stage DEV-1343 (#6498)

Compile the node app in a separate stage, then copy the production assets to 
the final production image.

Full --no-cache rebuilds should complete in less time, since 3 "slow parts"
can now happen in parallel. (pip, npm/webpack, and apt). Usually webpack
will finish building before apt step finishes. The "copy" itself takes a few
seconds, but the concurrency makes up for it.

Typical development scenarios should see an additional speedup in image
rebuilding, since the node_modules layers will remain the same quite often,
and are now cached unless their inputs change.

---

- Port `copy_fonts.py` to `.sh` so it can be run w/o Python
- Move `npm install` and the webpack prod build in Docker 'build stage'
- Rearrange some `Dockerfile` sections to optimize layer-based caching.
- Full `--no-cache` rebuilds should be faster than before, since they
allow the three "slow parts" to happen simultaneously.
- Docker image layers for node modules / webpack build steps will be
reused (take 0.0-5.0s) if their package dependencies or build inputs
haven't changed.

7045 of 11399 branches covered (61.8%)

27097 of 34296 relevant lines covered (79.01%)

0.79 hits per line