kobotoolbox / kpi / 21637299101 / 2

82%

master: 76%

push

github

refactor(dataCollectors): cleanup DEV-1560 (#6612)

### 💭 Notes
1. Cosmetic - renaming/moving methods and variables for consistency,
some additional clarifying documentation
2. Consistency - reraising errors in all methods instead of sometimes
swallowing them and sometimes not, treating member variables the same in
signals
3. Optimization - Replacing `keys` method, deemed unsafe in production

### 👀 Preview steps
Regression testing only.
Verify:
1. Creating a new data collector and adding them to a group - they
should now be able to see and submit to all projects belonging to the
group owner
4. Rotating a DC's token - all links should still work
5. Removing a DC from the group - links should no longer work
6. Deleting a DC group - DC links should no longer work
7. DC group's owner loses manage project permissions - DC links should
no longer work
8. Delete DC - DC links should not longer work

7287 of 11405 branches covered (63.89%)

27878 of 34286 relevant lines covered (81.31%)

0.81 hits per line