kobotoolbox / kpi / 21149213743 / 1

81%

master: 76%

push

github

feat(massEmails): exclude users who have submitted from inactive emails DEV-1585 (#6618)

### 📣 Summary
Exclude users who have recently made submissions to any project from
receiving inactive user emails.

### 📖 Description
Previously we only counted users as active if they submitted to their
own projects, but not projects owned by others.

### 💭 Notes
Even though submission attribution is complicated, it's a pretty safe
bet that if a user creates a submission it will create an Instance with
them as the user.

### 👀 Preview steps
Remember to restart the worker when switching between branches

1. ℹ️ have an existing account and a project that does not allow
anonymous submissions
2. Create a new user User A. Make sure they have an email
3. Grant User A permission to add submissions to an existing project
owned by someone else
4. In a Django shell, manually set User A's `date_joined` to something
over a year ago
5. Create a MassEmailConfig for users who have been inactive for a year
6. Generate the send list
7. :green_circle: User A should be in the send list
8. In a private browser window, open the survey link directly in enketo.
Log out of enketo if you are already logged in
9. Submit a response
10. Regenerate the send list for the email config
11. 🔴 [on main] User A will still be on the list
12. 🟢 [on PR] User A is no longer there

7030 of 11383 branches covered (61.76%)

27051 of 34236 relevant lines covered (79.01%)

0.79 hits per line