kobotoolbox / kpi / 21140395632 / 2

82%

master: 76%

push

github

feat(massEmails): exclude trashed users from email lists DEV-1171 (#6615)

### 📣 Summary
Ensure users who cannot log in do not receive emails.


### 📖 Description
Filter out any user who is already in the trash bin or who has been
explicitly set to not active (as distinguished from users who we
determine to be inactive by a lack of activity).


### 👀 Preview steps
Have Stripe enabled. Remember to restart the kpi worker when switching
from main to the PR branch.

1. ℹ️ have an account and a project
2. Create two users, A and B, both on the community plan. Make sure they
both have emails.
3. Create two MassEmailConfigs, one for users inactive for > 365 days
and one for users > 100% of their submissions limit
4. For User B, create a project and add 2 submissions
5. Update the Community plan in django admin to have `"submissions": 1`
in the metadata.
6. In a Django shell, manually set user a's `date_joined` to be more
than 90 days ago
7. Export the recipients list for both emails
8. :green_circle: User A should be in the inactive email, User B should
be in the usage email
9. In Django admin, remove (don't delete!) User A and User B. Verify
they are in the AccountTrash
10. Re-export the recipients list for both emails
11. 🔴 [on main] Both User A and User B are still on their respective
email lists
12. 🟢 [on PR] User A and User B have been removed

7255 of 11369 branches covered (63.81%)

27777 of 34168 relevant lines covered (81.3%)

0.81 hits per line