dnsimple / dns_erlang / 19826207533 / 1
84%
main: 84%

DEFAULT BRANCH: main
Ran
Files 9
Run time 0s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 78.925% (-0.1%) from 79.064%
19826207533.1

push

github

web-flow 
Support ecdsa (#84)

By @pawloos1:
This PR adds support for algorithm 13 (ECDSA P-256 SHA-256) used for DNSSEC. It consists of:
- hashing the data with SHA-256 for signing/verifying
- signing/verifying records with crypto's implementation of ECDSA algorithm
- encoding/decoding ECDSA keys
- new zone and keys for unit tests

By @NelsonVides:
- I've added support for the algorithm 14, as other than generating the zones from BIND for the test (which Gemini helped a lot generating) everything else was rather one-liners here and there.
- Refactored a tiny bit the dnssec_test suite to be a bit more readable, it is indeed not immediately obvious to see what are the tests checking, DNSSEC is sufficiently complex by itself. Gonna do some heavier refactoring later on on this.
- When it comes to DNSSEC, for NSEC/NSEC3 there's a stream of RFCs correcting each other about the TTL value of negative responses (2308->4035->9077). There're APIs for gen_nsec and gen_nsec3 that would pregenerate the chain for an entire zone that needed fixing in order to match what BIND returns.
    - Also, hey, didn't realise we can pregenerate these chains! We might want to do that in erldns so that at runtime the negative answers are also already constructed maybe? Less CPU usage at runtime 😄

Commits:

* Add macros for ECDSA algorithm number
* Minor refactoring
* Hashing data for signing/veryfying
* Signing records with ecdsa
* Verifying records with ecdsa
* Encoding/decoding ECDSA keys
* Add unit tests
* Formatting
* Implement wire encode/decode for (c)dnskey of both P256/P384 with tests
* Implement RFC9077 TTL handling for NSEC/NSEC3
* Add support for ecdsa p384 and fix crypto:verify/5 API with the 0x04 header
* Fix dialyzer

---------

Co-authored-by: Nelson Vides <nelson.vides@dnsimple.com>

1292 of 1637 relevant lines covered (78.92%)

408.15 hits per line

Source Files on job 19826207533.1