dnsimple / dns_erlang
92%

DEFAULT BRANCH: main
Repo Added
Token 72qZZkJyJVy2Od1Yh0lQQ62DENnvMSpMr regen
Build 338 Last
Files 12
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 91.914% (+0.01%) from 91.904%
30259340523

push

github

NelsonVides 
Decline zone transfers in decode_query/1 (rfc1995, rfc5936)

Two faults, one shape. The opcode 0 header guard from #101 required
NSCOUNT = 0, but rfc1995 §3 has an IXFR client state the serial it holds
by putting that SOA in the authority section, so every conformant IXFR
query was rejected as formerr; erldns drops what it cannot decode without
replying, so a secondary retried on a timer and never learned why. The
exemption was in #101's own survey, under miekg/dns: "Allows at most 1 RR
in Answer/Authority sections (for NOTIFY/IXFR)". NOTIFY got its clause.

Admitting the record is not enough, because nothing downstream knows what
a transfer is. Driving the erldns pipeline with a decoded IXFR gives
NOERROR, aa=true, an empty answer and the zone's SOA in authority: no
record carries type 251, so it resolves to NODATA like any other qtype
that matches nothing. That is worse than the formerr it replaces. rfc1995
§4 gives a lone SOA and nothing else the meaning "your copy is current",
and this reply is one SOA away from that, so a lenient secondary can read
it as confirmation that it is in sync with a zone it has never once
transferred. Silence at least fails loudly.

So decline them here, as the opcodes above already are. rfc1035 §4.1.1
defines NOTIMP as "the name server does not support the requested kind of
query", which is the literal truth: a transfer is answered as a stream of
messages over a held connection, and a caller that gets one decoded
message back cannot produce that. A server implementing transfers decodes
with decode_message/1 and runs its own loop, as it must regardless.

The check reads the decoded message rather than gating ahead of it. The
qtype lives in the question section, so testing it before decode_body/3
would parse the questions twice on every query to catch a rare one; two
clauses on the way out cost the same and only on the way out. AXFR needs
no authority record and never tripped the guard, but resolved to the same
NODATA, s... (continued)

2978 of 3240 relevant lines covered (91.91%)

11669.93 hits per line

Relevant lines Covered
3240 RELEVANT LINES 2978 COVERED LINES
11669.93 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
30259340523 main Decline zone transfers in decode_query/1 (rfc1995, rfc5936) Two faults, one shape. The opcode 0 header guard from #101 required NSCOUNT = 0, but rfc1995 §3 has an IXFR client state the serial it holds by putting that SOA in the authority section,... push NelsonVides github
91.91
30259042281 fix/rfc1995-ixfr-header-guard Merge 29bf3a84b into a17c8dc0d Pull #145 web-flow github
91.91
30253944014 main Decode rfc2136 UPDATE, and refuse to serve it with NOTIMP a4f90e2 made empty RDATA an error for every type in requires_rrdata/1, on the grounds that RFC 1035 §3.2.1 leaves no room for a known type to carry zero octets. rfc2136 is the exception: §... push NelsonVides github
91.9
30253826071 fix/rfc2136-update-decoding Merge a17c8dc0d into 51bd563f7 Pull #144 web-flow github
91.9
30161651760 main Keep non-canonically encoded RSA public keys opaque (RFC 3110 §2) RFC 3110 §2 lays an RSA key out as an exponent length -- one octet, or zero followed by two -- then the exponent and the modulus. Decoding turned those into the integer pair [E, M]... push NelsonVides github
91.88
30161550392 fix/optrr-uniqueness-and-rsa Merge 51bd563f7 into 831208fe4 Pull #143 web-flow github
91.88
30160754950 main Add wire-format properties for RDATA, and fix what they found Nothing checked that RDATA survives a trip through the wire codec: prop_wire_roundtrip in dns_domain_SUITE covers only domain names, and the properties in dns_zone_prop cover the prese... push NelsonVides github
91.22
30160713294 fix/wire-fidelity Merge 831208fe4 into 9f5e78f7d Pull #142 web-flow github
91.22
30160583170 fix/wire-fidelity Merge e3c77ba69 into 9f5e78f7d Pull #142 web-flow github
91.26
30157417737 main Honour an OPT RR anywhere in the additional section (RFC 6891 §6.1.1) RFC 6891 §6.1.1: the OPT RR "MAY be placed anywhere within the additional data section". Four places in the encoder matched it only at the head of that list -- get_max_size/2, ... push NelsonVides github
90.99
See All Builds (336)

Badge your Repo: dns_erlang

We detected this repo isn’t badged! Grab the embed code to the right, add it to your repo to show off your code coverage, and when the badge is live hit the refresh button to remove this message.
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

Refresh